On 24 November 2017 at 13:30, Eric Auger <eric.au...@redhat.com> wrote:
> From the very beginning, post_load() was called from common
> reset. This is not standard and obliged to discriminate the
> reset case from the restore case using the iidr value.
>
> Let's get rid of that call.
>
> Signed-off-by: Eric Auger <eric.au...@redhat.com>
> ---
> hw/intc/arm_gicv3_its_common.c | 2 --
> hw/intc/arm_gicv3_its_kvm.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_its_common.c b/hw/intc/arm_gicv3_its_common.c
> index f2cce59..2bd2f0f 100644
> --- a/hw/intc/arm_gicv3_its_common.c
> +++ b/hw/intc/arm_gicv3_its_common.c
> @@ -131,8 +131,6 @@ static void gicv3_its_common_reset(DeviceState *dev)
> s->creadr = 0;
> s->iidr = 0;
> memset(&s->baser, 0, sizeof(s->baser));
> -
> - gicv3_its_post_load(s, 0);
> }
>
> static void gicv3_its_common_class_init(ObjectClass *klass, void *data)
> diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
> index 6fb45df..b1b322b 100644
> --- a/hw/intc/arm_gicv3_its_kvm.c
> +++ b/hw/intc/arm_gicv3_its_kvm.c
> @@ -155,10 +155,6 @@ static void kvm_arm_its_post_load(GICv3ITSState *s)
> {
> int i;
>
> - if (!s->iidr) {
> - return;
> - }
> -
> kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_ITS_REGS,
> GITS_IIDR, &s->iidr, true, &error_abort);
>
> --
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
