Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v3] linux-user: Use *at functions instead of caching interp_prefix contents === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 214763a007 linux-user: Use *at functions instead of caching interp_prefix contents === OUTPUT BEGIN === Checking PATCH 1/1: linux-user: Use *at functions instead of caching interp_prefix contents... ERROR: do not use assignment in if condition #25: FILE: linux-user/elfload.c:2206: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #76: FILE: linux-user/syscall.c:7231: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #99: FILE: linux-user/syscall.c:7653: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #122: FILE: linux-user/syscall.c:8277: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #127: FILE: linux-user/syscall.c:8280: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #143: FILE: linux-user/syscall.c:8301: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #148: FILE: linux-user/syscall.c:8304: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #161: FILE: linux-user/syscall.c:8316: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #166: FILE: linux-user/syscall.c:8319: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #209: FILE: linux-user/syscall.c:9240: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #241: FILE: linux-user/syscall.c:9267: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #278: FILE: linux-user/syscall.c:9704: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #283: FILE: linux-user/syscall.c:9707: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #296: FILE: linux-user/syscall.c:9719: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #301: FILE: linux-user/syscall.c:9722: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #317: FILE: linux-user/syscall.c:10809: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #322: FILE: linux-user/syscall.c:10812: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #337: FILE: linux-user/syscall.c:10826: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #342: FILE: linux-user/syscall.c:10829: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #358: FILE: linux-user/syscall.c:10855: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #362: FILE: linux-user/syscall.c:10858: + if (interp_dirfd < 0 ERROR: do not use assignment in if condition #380: FILE: linux-user/syscall.c:11862: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #385: FILE: linux-user/syscall.c:11865: + if (interp_dirfd < 0 total: 23 errors, 0 warnings, 352 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
