On 16/01/2018 15:43, Daniel P. Berrange wrote: >> >> It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs >> now can have dedicated gcontext, we should always bind chardev tasks >> onto those gcontext rather than the default main context. Since there >> are quite a few of g_timeout_add[_seconds]() callers, a new function >> qemu_chr_timeout_add_ms() is introduced. > FYI the point of using g_timeout_add_seconds() is that it allow the > glib event loop to be more efficient. It ensures that all timers > which second granularity are dispatched on the same iteration of > the main loop. IOW, if you have 10 timers registered with > g_timeout_add_seconds() the main loop wakes up once a second and > runs all 10 of them. If you have 10 timers registered with g_timeout_add > the main loop wakes up 10 times a second, at a different time for each > timer.
Yes, that can be added back later. In our case, it may even hurt to synchronize all timeouts at the same time (if there are many of them) because the BQL can introduce jitter. But it is difficult to say without measuring. Paolo
