On 01/05/11 14:46, Anthony Liguori wrote: > On 01/05/2011 04:41 AM, jes.soren...@redhat.com wrote: >> From: Jes Sorensen<jes.soren...@redhat.com> >> >> strtosz() needs to return a 64 bit type even on 32 bit >> architectures. Otherwise qemu-img will fail to create disk >> images>= 2GB >> >> Signed-off-by: Jes Sorensen<jes.soren...@redhat.com> >> > > off_t would be the proper type to use.
I discussed this with Markus, and we both agree that it isn't. Two reasons, off_t is for filesystem offsets, not random sizes. Second, off_t doesn't have an unsigned type or a max to compare against. Using int64_t is cleaner and safer. Cheers, Jes
