On 2017-12-19 17:37, Philippe Mathieu-Daudé wrote: > 'make check-block' uses it on Linux. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index b4bcc872f2..fa5e9597f1 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -919,7 +919,7 @@ check-qapi-schema: $(patsubst %,check-%, > $(check-qapi-schema-y)) check-tests/qap > check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) > check-unit: $(patsubst %,check-%, $(check-unit-y)) > check-speed: $(patsubst %,check-%, $(check-speed-y)) > -check-block: $(patsubst %,check-%, $(check-block-y)) > +check-block: $(patsubst %,check-%, $(check-block-y)) > QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) > check: check-qapi-schema check-unit check-qtest > check-clean: > $(MAKE) -C tests/tcg clean
First, shouldn't it be $(QEMU_IOTESTS_HELPERS-y)? Secondly, it seems that is already a dependency of check-tests/qemu-iotests-quick.sh, which is basically what $(check-block-y) is. So even without that dependency here, socket_scm_helper is built when I run make check-block and it's missing. Max
signature.asc
Description: OpenPGP digital signature
