Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180205102935.14736-1-da...@redhat.com
Subject: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for
Multiple-epoch facility
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180205102659.60552-1-mar...@redhat.com ->
patchew/20180205102659.60552-1-mar...@redhat.com
* [new tag] patchew/20180205102935.14736-1-da...@redhat.com ->
patchew/20180205102935.14736-1-da...@redhat.com
Switched to a new branch 'test'
7c277a23c1 s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility
=== OUTPUT BEGIN ===
Checking PATCH 1/1: s390x/cpumodel: model PTFF subfunctions for Multiple-epoch
facility...
ERROR: line over 90 characters
#25: FILE: target/s390x/cpu_features.c:159:
+ FEAT_INIT("ptff-qsie", S390_FEAT_TYPE_PTFF, 10, "PTFF Query Steering
Information Extended"),
ERROR: line over 90 characters
#26: FILE: target/s390x/cpu_features.c:160:
+ FEAT_INIT("ptff-qtoue", S390_FEAT_TYPE_PTFF, 13, "PTFF Query TOD Offset
User Extended"),
WARNING: line over 80 characters
#29: FILE: target/s390x/cpu_features.c:163:
+ FEAT_INIT("ptff-stoe", S390_FEAT_TYPE_PTFF, 73, "PTFF Set TOD Offset
Extended"),
WARNING: line over 80 characters
#30: FILE: target/s390x/cpu_features.c:164:
+ FEAT_INIT("ptff-stoue", S390_FEAT_TYPE_PTFF, 77, "PTFF Set TOD Offset User
Extended"),
ERROR: line over 90 characters
#38: FILE: target/s390x/cpu_features.c:452:
+ FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements
introduced with Multiple-epoch facility"),
ERROR: Macros with complex values should be enclosed in parenthesis
#67: FILE: target/s390x/gen-features.c:62:
+#define S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF \
+ S390_FEAT_PTFF_QSIE, \
+ S390_FEAT_PTFF_QTOUE, \
+ S390_FEAT_PTFF_STOE, \
+ S390_FEAT_PTFF_STOUE
total: 4 errors, 2 warnings, 80 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
