On 08/02/2018 15:58, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 03:38:59PM +0200, Marcel Apfelbaum wrote: >> We do not "use" the __u32 types, we just copied a kernel file >> for structures used for communication between the guest driver >> and the QEMU code. We had a look on how it is done and >> we use the model that adds macros __u32 -> uint32_t, >> so the "__types" do not really create such problems. > > I don't think this is done like this anywhere in code.
It is used in vmxnet. > Please take a look at how it's done for e.g. input.h > I will use it as reference. > I think that whenever a rule in HACKING, coding style, > etc is ignored it should be accompanied by motivation > in code comments, so this won't spread out any more. > Agreed, I will update the code accordingly. Thanks, Marcel
