On Wed, 14 Feb 2018 09:16:15 -0600 Eric Blake <ebl...@redhat.com> wrote:
> On 02/14/2018 04:57 AM, Cornelia Huck wrote: > > On Tue, 13 Feb 2018 18:18:45 +0100 > > Viktor Mihajlovski <mihaj...@linux.vnet.ibm.com> wrote: > > > > >> Patch 1/3: > >> Adds architecture specific data to the QMP CpuInfo type, exposing > >> the existing s390 cpu-state in QMP. The cpu-state is a representation > >> more adequate than the ambiguous 'halted' condition. > >> > >> Patch 2/3: > >> Adds a new QMP function query-cpus-fast, which will only retrieve > >> vCPU information that can be obtained without interrupting the > >> vCPUs of a running VM. It introduces a new return type CpuInfoFast > >> with the subset of fields meeting this condition. Specifically, the > >> halted state is not part of CpuInfoFast. QMP clients like libvirt > >> are encouraged to switch to the new API for vCPU information. > >> > >> Patch 3/3: > >> Adds the s390-specific cpu state to CpuInfoFast, allowing management > >> apps to find out whether a vCPU is in the stopped state. This extension > >> leads to a partial duplication of field definitions from CpuInfo > >> to CpuInfoFast. This should be tolerable if CpuInfo is deprecated and > >> eventually removed. > > > > How shall we proceed with this series? Patch 3 depends upon patch 1, so > > I think it makes sense to merge this in one go. > > > > I can give my R-b on patch 1 and Someone(tm) can merge this, or I can > > take the whole series through the s390 tree (with some further > > reviews/acks on patches 2/3). > > I'd still like to give a thorough QMP review; it's on my list to get to > today. > Sure, no need to hurry.