On 14.02.2018 18:46, Collin L. Walling wrote: > I'm beginning to like the usage of splash-time to represent a timeout > for the boot menu > less and less. It is really meant for how long a _splash_ _image_ > should appear during boot. > > I'd like to suggest adding a new boot option "menu-timeout". An > alternative would be > documenting in qemu-options.hx that s390 treats "splash-time" as the > menu-timeout. > > Thoughts?
I think you should keep splash-time and not introduce a new option. Libvirt seems to map the timeout from <bootmenu enable='yes' timeout='X'/> to the splash-time option, and according to the libvirt documentation: "Additional attribute timeout takes the number of milliseconds the boot menu should wait until it times out." So it seems like splash-time is already expected to define the amount of time for the boot menu. We should not confuse libvirt or the users by introducing yet another option here. Thomas > On 02/05/2018 03:57 PM, Collin L. Walling wrote: >> Set boot menu options for an s390 guest and store them in >> the iplb. These options are set via the QEMU command line >> option: >> >> -boot menu=on|off[,splash-time=X] >> >> or via the libvirt domain xml: >> >> <os> >> <bootmenu enable='yes|no' timeout='X'/> >> </os> >> >> Where X represents some positive integer representing >> milliseconds. >> >> Any value set for loadparm will override all boot menu options. >> If loadparm=PROMPT, then the menu will be enabled without a >> timeout. >> >> The absence of any boot options on the command line will flag >> to later use the zipl boot loader values. >> >> Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> >> Reviewed-by: Janosch Frank <fran...@linux.vnet.ibm.com> >> Reviewed-by: Thomas Huth <th...@redhat.com> >> --- >> [...]