On Mon 19 Feb 2018 05:44:23 PM CET, Eric Blake <ebl...@redhat.com> wrote: > On 02/19/2018 08:54 AM, Alberto Garcia wrote: >> This patch updates docs/qcow2-cache.txt explaining how to use the new >> l2-cache-entry-size parameter. >> >> Here's a more detailed technical description of this feature: >> >> https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html >> >> And here are some performance numbers: >> >> https://lists.gnu.org/archive/html/qemu-block/2017-12/msg00507.html >> >> Signed-off-by: Alberto Garcia <be...@igalia.com> >> --- >> docs/qcow2-cache.txt | 46 +++++++++++++++++++++++++++++++++++++++++++--- >> 1 file changed, 43 insertions(+), 3 deletions(-) >> > >> +Some things to take into account: >> + >> + - The L2 cache entry size has the same restrictions as the cluster >> + size (power of two, at least 512 bytes). > > Worth mentioning the upper limit of the cluster size?
I thought it would be unnecessary since the that's already mentioned several times in the text ("you can change the size [...] and make it smaller than the cluster size", "Using smaller cache entries"), and I think it's pretty obvious if you actually read that section. Berto