On 27 February 2018 at 10:49, Linus Walleij <linus.wall...@linaro.org> wrote: > This adds the SiI9022 and EDID I2C devices to the ARM Versatile > Express machine, and selects the two I2C devices necessary in the > arm-softmmy.mak configuration so everything will build smoothly. > > I am implementing proper handling of the graphics in the Linux > kernel and adding proper emulation of SiI9022 and EDID makes the > driver probe as nicely as before, retrieveing the resolutions > supported by the "QEMU monitor" and overall just working nice. > > The assignment of the SiI9022 at address 0x39 and the EDID > DDC I2C at address 0x50 is not strictly correct: the DDC I2C > is there all the time but in the actual component it only > appears once activated inside the SiI9022, so ideally it should > be added and removed to the bus by the SiI9022. However for this > purpose it works fine to just have it around.
This last paragraph in the commit message can just be removed now the DDC I2C isn't created here, right? > Cc: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org> > --- > ChangeLog v1->v2: > - Only add the SII9022 now that it will by itself realize > the DDCI2C as part of the bridge. > --- > default-configs/arm-softmmu.mak | 2 ++ > hw/arm/vexpress.c | 6 +++++- > 2 files changed, 7 insertions(+), 1 deletion(-) (if this is the only problem with the patchset I'll just fix it up in my tree) thanks -- PMM