On 27 February 2018 at 10:49, Linus Walleij <linus.wall...@linaro.org> wrote: > This adds support for emulating the Silicon Image SII9022 DVI/HDMI > bridge. It's not very clever right now, it just acknowledges > the switch into DDC I2C mode and back. Combining this with the > existing DDC I2C emulation gives the right behavior on the Versatile > Express emulation passing through the QEMU EDID to the emulated > platform. > > Cc: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
> +typedef struct sii9022_state { > + I2CSlave parent_obj; > + uint8_t ptr; > + bool addr_byte; > + bool ddc_req; > + bool ddc_skip_finish; > + bool ddc; > +} sii9022_state; > +static void sii9022_reset(DeviceState *dev) > +{ > + sii9022_state *s = SII9022(dev); > + > + s->ptr = 0; > + s->addr_byte = false; I asked about reset before -- can we just add s->ddc_req = false; s->ddc_skip_finish = false; s->ddc = false; ? thanks -- PMM