On Mon, 2018-02-26 at 19:22 +1100, Alexey Kardashevskiy wrote: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > It does not handle abstract classes either. > > This adds a new qom-list-properties command which prints properties > of a specific class and its instance. It is pretty much a simplified copy > of the device-list-properties handler. > > Since it creates an object instance, device properties should appear > in the output as they are copied to QOM properties at the instance_init > hook. > > This adds a object_class_property_iter_init() helper to allow class > properties enumeration uses it in the new QMP command to allow properties > listing for abstract classes. > > Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> > --- > Changes: > v2: > * added abstract classes support, now things like "pci-device" or > "spapr-machine" show properties, previously these would produce > an "abstract class" error
This is really nice, since it means libvirt won't have to figure out the class name based on the default machine type but will be able to simply list properties for the base class. I'm going to implement support for this new command in libvirt and report back if I run into any issue with the current design, but it looks very good so far. -- Andrea Bolognani / Red Hat / Virtualization
