On Fri, Mar 2, 2018 at 2:57 AM, Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote: > > From: Or Idgar <orid...@gmail.com> > > > > This patch allow changing the Virtual Machine Generation > > ID through QMP/HMP while the vm guest is running. > > the spec (http://go.microsoft.com/fwlink/?LinkId=260709) > > mentions that "when the generation ID changes, execute an > > ACPI Notify operation on the generation ID device". > > To test it we need the ability to set the generation ID > > online. QMP/HMP allows that. > > If we want to test vmgenid, why don't we simply trigger one of > the mgmt actions that are required to change vmgenid. eg do a > savevm, followed by a loadvm to restore from snapshot. This would > be better testing of the real world usage of this feature. > > I agree. Verifying functionality in a Windows guest is tricky, but in Linux you can build and load this (old and badly written) device driver: https://github.com/ben-skyportsystems/vmgenid-test You should see the 'notices' number increment after restoring a snapshot. Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/ > dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/ > dberrange :| > regards, Ben