On 07/03/18 09:39, Thomas Huth wrote:

The global hack for creating SCSI devices has recently been removed,
but this apparently broke SCSI devices on some boards that were not
ready for this change yet. For the sun4m machines you now get:

$ sparc-softmmu/qemu-system-sparc -boot d -cdrom x.iso
qemu-system-sparc: -cdrom x.iso: machine type does not support 

Fix it by calling scsi_bus_legacy_handle_cmdline() after creating the
corresponding SCSI controller.

Reported-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
Fixes: 1454509726719e0933c800fad00d6999752688ea
Signed-off-by: Thomas Huth <th...@redhat.com>
  hw/sparc/sun4m.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 61eb424..0f5804b 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -324,6 +324,7 @@ static void *sparc32_dma_init(hwaddr dma_base,
esp = ESP_STATE(object_resolve_path_component(OBJECT(espdma), "esp"));
      sysbus_mmio_map(SYS_BUS_DEVICE(esp), 0, esp_base);
+    scsi_bus_legacy_handle_cmdline(&esp->esp.bus);
ledma = SPARC32_LEDMA_DEVICE(object_resolve_path_component(
                                   OBJECT(dma), "ledma"));

Hi Thomas,

Thanks for the patch - I can confirm that it resolves the issue with qemu-system-sparc.

Tested-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>

I presume it makes sense for this to go through a tree along with the other patches in the set rather than me taking this via my qemu-sparc branch?



Reply via email to