On Thu, Mar 08, 2018 at 11:19:30AM +0000, Peter Maydell wrote: > On 8 March 2018 at 11:10, Michael Clark <m...@sifive.com> wrote: > > > > On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell <peter.mayd...@linaro.org> > > wrote: > >> > >> On 6 March 2018 at 19:46, Michael Clark <m...@sifive.com> wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA1 > >> > > >> > The following changes since commit > >> > f32408f3b472a088467474ab152be3b6285b2d7b: > >> > > >> > misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 > >> > +0000) > >> > > >> > are available in the git repository at: > >> > > >> > https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream-v8.2 > >> > > >> > for you to fetch changes up to 7051b081bf6796e5e84406f6223a7c4900bf7298: > >> > > >> > RISC-V - Remove support for adhoc non-standard X_COP local-interrupt > >> > (2018-03-07 08:36:03 +1300) > >> > >> > >> Hi -- I would have applied this, but some of the commits > >> have no signed-off-by lines. > >> > >> This is important, and I've already asked for it once. We cannot > >> accept anything that doesn't have a clear record in the commit > >> message of everybody (person or company) who's contributed code > >> to it, indicating that they're happy for their copyrighted > >> contributions to be taken into QEMU under our license. Lists > >> of names without emails in the cover letter are not sufficient. > >> > >> In fact a lot of the last part of this patchset looks like > >> unreviewed changes/fixes that if we were going to have them we > >> should have squashed into the correct patches and resent the > >> series for review. Please don't do this. Code review is an > >> important part of how the QEMU project works. > > > > > > You must be looking at the wrong tag. There are multiple sign-offs in all 23 > > commits. The tag is riscv-qemu-upstream-v8.2. Sagar and Bastian contacted me > > out of band to add their sign-offs. Please look at the commits again and > > tell me which commit id doesn’t have a sign-off on that tag (23 commits > > iirc) > > I'm looking at the one this email tells me to pull: > https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream-v8.2 > changes up to 7051b081bf6796e5e84406f6223a7c4900bf7298 > > Commit 7051b081bf6796e5e84406f6223a7c4900bf7298, > 9390ed5f4ca5fd3bde10ee2dcf4e7d915d1c189d, > b38548c4057fb670950a4b94efe5c03b8aba4118, > etc etc all have no signoff.
There's something peculiar going on when fetching the PR. I did a 'git fetch riscv/riscv-qemu-upstream-v8.2' which pulled into FETCH_HEAD. If i do 'git log FETCH_HEAD' then I see those commits you mention as missing signoff. If I instead do 'git log riscv-qemu-upstream-v8.2' then all the commits have signoffs - it ranges 4dc62b15323bb6338c4b426f76e92be55f87db8c...25fa194b7b11901561532e435beb83d046899f7a. I'm confused why pulling the tag is populating extra commits into FETCH_HEAD, that are seemingly not part of the tag. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
