Block drivers can be selected by either protocol syntax: <protocol>:<filename>[:options]
or explicitly: driver=<driver>[,option=<opt1>...] For the protocol syntax to work, drivers should set the protocol_name field of the BlockDriver structure and provide bdrv_file_open and bdrv_parse_filename implementations. Conversely, block drivers that do not support the protocol syntax should instead implement bdrv_open and not have a protocol_name field. Some drivers do not currently adhere to this and errors arise when trying to select them using the protocol syntax. For instance: $ qemu-img info replication:foo qemu-img: block.c:2401: bdrv_open_inherit: \ Assertion `!!(flags & BDRV_O_PROTOCOL) == !!drv->bdrv_file_open' failed. Aborted (core dumped) This patch-set ensures that the following drivers are meeting the above criteria: - blkreplay - quorum - replication - throttle Aside from that, documentation was added to make the above more explicit. Fabiano Rosas (5): block/replication: Remove protocol_name field block/quorum: Remove protocol-related fields block/throttle: Remove protocol-related fields block/blkreplay: Remove protocol-related fields include/block/block_int: Document protocol related functions block/blkreplay.c | 3 +-- block/quorum.c | 3 +-- block/replication.c | 1 - block/throttle.c | 3 +-- include/block/block_int.h | 6 ++++++ replication.h | 1 - 6 files changed, 9 insertions(+), 8 deletions(-) -- 2.13.6