On Wed, 14 Mar 2018 11:48:46 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote:
>On 12/03/2018 19:33, Alexey Gerasimenko wrote: >> xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq >> xen_piix3_set_irq --> xen_cmn_set_irq > >Don't abbrvt names, xen_hvm_ is a better prefix. Agree, will rename xen_cmn_* to xen_hvm_* >> + fprintf(stderr, "WARNING: guest domain >> attempted to use PIRQ%c " >> + "routing which is not supported for >> Xen/Q35 currently\n", >> + (char)(address - ICH9_LPC_PIRQE_ROUT + >> 'E')); > >Use error_report instead. OK, will change to error_report(). There are multiple fprintf(stderr,...)'s still left in the file though, an additional cleanup patch to replace all such instances to error_report() calls might be needed later.
