On 13 March 2018 at 23:16, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > On 03/13/2018 06:09 PM, Peter Maydell wrote: >> On 13 March 2018 at 16:55, Andrew Baumann <andrew.baum...@microsoft.com> >> wrote: >>> At some point I remember seeing a patch to change this to cortex-a7. Is >>> there a reason we didn't make that change? >>> >>> (Background: the real Pi2 has an A7. When I first implemented the machine >>> model there was no A7 emulation in QEMU, so I used the A15 which was the >>> closest equivalent.) >> >> Yeah, we should do that. I'd forgotten about that, I think >> things just got lost in the shuffle of having several >> patchsets that tried to change the same things at once. >> >> I guess the simplest thing is to add a patch at the end of >> the series that fixes the cpu type for bcm2836. > > Peter, here is the patch Andrew remembered (maybe can be applied at the > end): > http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg04286.html
Thanks for finding that. It doesn't apply after this refactoring, but I'll send out a patch which does the equivalent thing in the new code. In the meantime I'm going to apply this patchset to target-arm.next since I'm going to send out a pullreq with bugfixes for rc0 today. thanks -- PMM