On 20 January 2011 17:16, Christophe Lyon <christophe.l...@st.com> wrote: > Set the right overflow bit for neon 32 and 64 bit saturating add/sub. > > Also move the neon 64 bit saturating add/sub helpers to neon_helper.c > for consistency with the 32 bits versions. > > There is probably still room for code commonalization though. > > Peter, this patch is based upon your patch 6f83e7d and adds the 64 bits case. > > Signed-off-by: Christophe Lyon <christophe.l...@st.com> > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
You shouldn't really leave my sign-off in there if you've changed the patch. (Actually a lot of the changes in the tree I pointed you at have my sign-off and really oughtn't -- all I was doing was splitting and rearranging existing meego commits, so those are all unreviewed / untested; so you should just remove it anyway.) I'll review this tomorrow. -- PMM