Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180329213857.15499-1-ehabk...@redhat.com Subject: [Qemu-devel] [RFC 00/18] QEMU validator: A method to specify QEMU crash-test cases === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180330170209.20627-1-rka...@virtuozzo.com -> patchew/20180330170209.20627-1-rka...@virtuozzo.com * [new tag] patchew/20180330195928.15607-1-jcmvb...@gmail.com -> patchew/20180330195928.15607-1-jcmvb...@gmail.com Switched to a new branch 'test' 0fdb1a2f05 Collection of validator.py test cases 962c7b9a45 validator.py script 11125125d8 qemu.py: is_launched() method e7b9360fc7 qemu.py: qmp_obj() method 04f1d03e56 qemu.py: Don't try to quit cleanly on exceptions b504207869 qemu.py: 'force' parameter on shutdown() 9cfedb7337 qemu.py: Only wait for process if it's still running 8c7e843d6e qemu.py: Log crashes inside _post_shutdown() 992c1b6bb2 qemu.py: Set _launched = False on _post_shutdown 9e4bcb4215 qemu.py: Make monitor optional 4d78dabfe2 qemu.py: Close _qmp inside _post_shutdown() 3937ce28e2 qemu.py: Use wait() logic inside shutdown() c2b5140e3d qemu.py: Move _load_io_log() call to _post_shutdown() a20254c9e0 qemu.py: Split _base_args() bb5e609a6b qemu.py: Make _vm_monitor a method a571feea0c qmp.py: Cleanly handle unexpectedly closed socket 9a92759c0c qmp.py: Fix error handling for Python 3 1f8f56095d qmp.py: Make it safe to call close() any time === OUTPUT BEGIN === Checking PATCH 1/18: qmp.py: Make it safe to call close() any time... Checking PATCH 2/18: qmp.py: Fix error handling for Python 3... Checking PATCH 3/18: qmp.py: Cleanly handle unexpectedly closed socket... Checking PATCH 4/18: qemu.py: Make _vm_monitor a method... Checking PATCH 5/18: qemu.py: Split _base_args()... Checking PATCH 6/18: qemu.py: Move _load_io_log() call to _post_shutdown()... Checking PATCH 7/18: qemu.py: Use wait() logic inside shutdown()... Checking PATCH 8/18: qemu.py: Close _qmp inside _post_shutdown()... Checking PATCH 9/18: qemu.py: Make monitor optional... Checking PATCH 10/18: qemu.py: Set _launched = False on _post_shutdown... Checking PATCH 11/18: qemu.py: Log crashes inside _post_shutdown()... Checking PATCH 12/18: qemu.py: Only wait for process if it's still running... Checking PATCH 13/18: qemu.py: 'force' parameter on shutdown()... Checking PATCH 14/18: qemu.py: Don't try to quit cleanly on exceptions... Checking PATCH 15/18: qemu.py: qmp_obj() method... Checking PATCH 16/18: qemu.py: is_launched() method... Checking PATCH 17/18: validator.py script... WARNING: line over 80 characters #188: FILE: scripts/validator.py:169: + self.alldevs = qom_type_names(vm, implements='device', abstract=False) WARNING: line over 80 characters #191: FILE: scripts/validator.py:172: + self.no_user_devs = [d['name'] for d in info_qdm(vm, ) if d['no-user']] WARNING: line over 80 characters #193: FILE: scripts/validator.py:174: + self.user_devs = [dev for dev in self.alldevs if dev not in self.no_user_devs] WARNING: line over 80 characters #195: FILE: scripts/validator.py:176: + self.cpu_models = [c['name'] for c in vm.command('query-cpu-definitions')] ERROR: line over 90 characters #301: FILE: scripts/validator.py:282: + >>> list(tc) == [{'a':[i], 'b':[j], 'c':[100, 200, 300]} for i in [1,2] for j in [10, 20]] ERROR: line over 90 characters #362: FILE: scripts/validator.py:343: + self._vars = dict((v, getattr(BuiltinVars, v)()) for v in dir(BuiltinVars) if not v.startswith('_')) WARNING: line over 80 characters #372: FILE: scripts/validator.py:353: + Default values override the values returned by VariableDefinition.enumerate() WARNING: line over 80 characters #392: FILE: scripts/validator.py:373: + """Return full list of variables, including dependencies in the right order ERROR: line over 90 characters #411: FILE: scripts/validator.py:392: + raise Exception("Variable dependency cycle: %s" % (' -> '.join(vars.keys()))) ERROR: line over 90 characters #530: FILE: scripts/validator.py:511: + vars = vars_for_template(self.get('command-line')) + vars_for_template(self.get('monitor-commands')) WARNING: line over 80 characters #548: FILE: scripts/validator.py:529: + return ' '.join('%s=%s' % (k, shquote(v)) for k,v in self.values.items()) WARNING: line over 80 characters #588: FILE: scripts/validator.py:569: + raise InvalidSpecification("Invalid monitor command: %r: %r" % (k, v)) ERROR: line over 90 characters #688: FILE: scripts/validator.py:669: + help="Run all test case combinations, not just the default for the test specification") ERROR: line over 90 characters #702: FILE: scripts/validator.py:683: + logging.basicConfig(stream=sys.stdout, level=args.loglevel, format='%(levelname)s: %(message)s') total: 6 errors, 8 warnings, 724 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/18: Collection of validator.py test cases... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com