On 16 April 2018 at 08:57, Christophe Lyon <christophe.l...@st.com> wrote: > On 13/04/2018 17:04, Peter Maydell wrote: >> I think we should just have support for these binaries enabled >> always. Otherwise it will bitrot because nobody compiles it. >> > We are relying on a pre-existing CONFIG_USE_FDPIC, which is currently > never defined. This was introduced by commit 1af02e83 back in 2011, > and indeed if you try to build QEMU with CONFIG_USE_FDPIC, the build fails > because elf_is_fdpic() is not defined.
This looks like an excellent demonstration of why we shouldn't hide this feature behind a defaults-to-off #define :-) > Do you suggest removing CONFIG_USE_FDPIC? Yes. Given how old the existing disabled FDPIC code is, I would also suggest you carefully review any of it that you're using... thanks -- PMM