On Mon, Apr 16, 2018 at 03:47:06PM +0800, Stefan Hajnoczi wrote: > On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB > > Naming suggestion: "PREFILL_IOTLB" instead of "NEED_ALL_IOTLB". > > I wasn't able to guess what "NEED_ALL_IOTLB" does. "PREFILL_IOTLB" > communicates that memory translation will be set up in advance.
By naming it as NEED_ALL_IOTLB, I want to indicate that, without this, it's hard or impossible for backend to get all the IOTLBs (because backend needs to meet IOVAs first before getting the corresponding IOTLBs, and backend can't tell whether it has met all the IOVAs or not, especially when dynamic mapping is being used by guest). But with this feature negotiated, backend will expect to get all the IOTLBs. But it seems that, the name (NEED_ALL_IOTLB) isn't good. And thanks for your suggestion! :) Best regards, Tiwei Bie