On Thu, Apr 19, 2018 at 07:35:57PM +0200, Paolo Bonzini wrote: > On 19/04/2018 19:27, Michael S. Tsirkin wrote: > > > > That CONFIG_SMP here is clearly wrong but I don't really know what > > to set it to. Also, we probably should switch virtio_wmb to dma_XX > > barriers. > > > > That's actually easy. Will try to do. > > Should it be dma_wmb() before updating the indices, and wmb() before > writing the "kick virtqueue" register? > > Paolo
if anything kick virtqueue should do wmb internally within virtio pci. No one uses strong barriers with virtio pci right now so we don't do it. -- MST
