On 24 May 2018 at 23:34, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> Since 2f652224f7, we now check if socket_set_nodelay() errored,
> but forgot to close the socket before reporting an error.
>
> Fixes: Coverity CID 1391290 (RESOURCE_LEAK)
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> gdbstub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index e4ece2f5bc..9c860cd81c 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1836,6 +1836,7 @@ static bool gdb_accept(void)
> /* set short latency */
> if (socket_set_nodelay(fd)) {
> perror("setsockopt");
> + close(fd);
> return false;
> }
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
