On 05/30/2018 05:23 PM, John Snow wrote: > On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote: >> Use error_report() + abort() instead of error_setg(&error_abort), >> as suggested by the "qapi/error.h" documentation: >> >> Please don't error_setg(&error_fatal, ...), use error_report() and >> exit(), because that's more obvious. >> Likewise, don't error_setg(&error_abort, ...), use assert(). >> > > Didn't realize this was bad form (Why do we have it?) > >> Use abort() instead of the suggested assert() because the error message >> already got displayed. >> > > Update the suggestion?
Fair enough. >> Suggested-by: Eric Blake <ebl...@redhat.com> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Reviewed-by: John Snow <js...@redhat.com> > Acked-by: John Snow <js...@redhat.com> Thanks!
