On 06/12/2018 02:30 PM, Richard Henderson wrote: > On 06/11/2018 04:17 AM, Peter Maydell wrote: >> The codebase has a bit of a mix of different multiline >> comment styles. State a preference for the Linux kernel >> style: >> /* >> * Star on the left for each line. >> * Leading slash-star and trailing star-slash >> * each go on a line of their own. >> */ >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> This is not my personal favourite, but seemed to be the >> closest we had to consensus in the mail thread for v1; >> I can live with it in order to avoid getting patches which >> use the styles I like even less :-) > > Honestly, I don't like this except for "important" comments. > > A "small" comment, e.g. one that doesn't quite fit on a single line, now takes > 4 lines instead of 2. Which is really annoying and IMO tends to break flow. > > If you don't like > > /* gnu > style */ > > or > > /* whatever > * this is */ > > could you live with > > // c99/c++ > // comments > > (I know we currently deny those in checkpatch, but that's easy enough to > remove > if we're changing policy. I have no idea why we don't like them in the first > place. Or other c99 features like mid-block or control declarations, for that > matter.)
+1 for control declarations :) Code is easier to read and keep focus on. 3.0 release is a good opportunity to establish such disruptive changes.
