On 06/26/2018 06:29 AM, Peter Maydell wrote: >> + e2 = (flip ? ni : nr); >> + e1 = (flip ? mi : mr) ^ neg_real; >> + e4 = e2; >> + e3 = (flip ? mr : mi) ^ neg_imag; > > These don't seem to match up with the pseudocode, which > applies the neg_real or neg_imag negations to element2, > not element1/3. I think the operations are correct but the > variable names are confusingly swapped.
Yes, I know. They have different names between the SVE document and the main ARM ARM. You swapped them to match the ARM when you applied the ARMv8.3-FCMA patch set, and I copied code from vec_helper.c to write this. Which is least confusing? r~
