On Wed, Jul 18, 2018 at 02:12:56PM -0700, Nishanth Aravamudan wrote:
> In ed6e2161 ("linux-aio: properly bubble up errors from initialzation"),
> I only added a bdrv_attach_aio_context callback for the bdrv_file
> driver. There are several other drivers that use the shared
> aio_plug callback, though, and they will trip the assertion added to
> aio_get_linux_aio because they did not call aio_setup_linux_aio first.
> Add the appropriate callback definition to the affected driver
> definitions.
>
> Fixes: ed6e2161 ("linux-aio: properly bubble up errors from initialization")
> Reported-by: Farhan Ali <al...@linux.ibm.com>
> Signed-off-by: Nishanth Aravamudan <naravamu...@digitalocean.com>
> Cc: Eric Blake <ebl...@redhat.com>
> Cc: Kevin Wolf <kw...@redhat.com>
> Cc: John Snow <js...@redhat.com>
> Cc: Max Reitz <mre...@redhat.com>
> Cc: Stefan Hajnoczi <stefa...@redhat.com>
> Cc: Fam Zheng <f...@redhat.com>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc: qemu-bl...@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> block/file-posix.c | 3 +++
> 1 file changed, 3 insertions(+)This patch looks good. The remaining s390 crash can be debugged separately. The FreeBSD host_cdrom change isn't strictly necessary (no Linux AIO on FreeBSD), but it doesn't hurt to call raw_aio_attach_aio_context() for consistency. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
signature.asc
Description: PGP signature
