On 07/27/2018 05:13 PM, Markus Armbruster wrote: > qtest_qmp_discard_response(...) is shorthand for > qobject_unref(qtest_qmp(...), except it's not actually shorter.
But the latter is IMHO harder to read. And it might be shorter in the compiled binary (one function call vs. two). > Moreover, the presence of these functions encourage sloppy testing. Shouldn't we then rather fix the tests to check for valid responses instead of replacing this function with harder-to-read code? Thomas
