On 08/08/2018 07:02 PM, Juan Quintela wrote: > Thomas Huth <th...@redhat.com> wrote: [...] > I didn't want to go "further", but I think that we should have here is > something like: > > check-qtest-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF) > gcov-files-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c > > and remove the arch specific bits. If one arch don't support it, we > know have CONFIG_USB_XHCI bits to not _enable_ it there. > > What do you think? > > Thanks, Juan.
If "make check" passes with that change, that sounds like the right solution to me, too. Thomas