On 08/10/2018 09:18 AM, Markus Armbruster wrote:
Eric Blake <ebl...@redhat.com> writes:
On 08/08/2018 07:02 AM, Markus Armbruster wrote:
utf8_string() tests only double quoted strings. Cover single quoted
strings, too: store the strings to test without quotes, then wrap them
in either kind of quote.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
tests/check-qjson.c | 427 ++++++++++++++++++++++----------------------
1 file changed, 214 insertions(+), 213 deletions(-)
Pre-existing, but:
/* 2.2.4 4 bytes U+1FFFFF */
Technically, Unicode ends at U+10FFFF (21 bits). Anything beyond that
is not valid Unicode, even if it IS a valid interpretation of UTF-8
encoding.
Correct. Testing how we handle such sequences makes sense all the same.
{
- "\"\xF7\xBF\xBF\xBF\"",
+ "\xF7\xBF\xBF\xBF",
NULL, /* bug: rejected */
So, maybe all the more we need to do is remove the comment (as we WANT
to reject these)?
The conversion of the initializer looks sane (well, mechanical). Ergo:
Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks!
Of course, playing games with the pre-existing comments on out-of-range
behavior is probably better for a separate patch, and you do have some
churn on these tests in later patches. I'll leave it up to you what to
do (or leave put).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
