On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-pci.c | 74 -------------------------- > hw/virtio/virtio-serial-pci.c | 97 +++++++++++++++++++++++++++++++++++ > tests/Makefile.include | 12 ++--- > 4 files changed, 104 insertions(+), 80 deletions(-) > create mode 100644 hw/virtio/virtio-serial-pci.c [...] > diff --git a/tests/Makefile.include b/tests/Makefile.include > index a1352ccefb..8666206ea4 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -143,7 +143,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF) > check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF) > check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF) > ifneq (,$(findstring qemu-ga,$(TOOLS))) > -check-unit-$(CONFIG_LINUX) += tests/test-qga$(EXESUF) > +check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += > tests/test-qga$(EXESUF)
Maybe mention qga's dependency in the patch description? Anyway: Reviewed-by: Thomas Huth <th...@redhat.com>
