On Thu, 27 Sep 2018, Philippe Mathieu-Daudé wrote: > > +static void gen_mul_r5900(DisasContext *ctx, uint32_t opc, > > + int acc, int rd, int rs, int rt) > > Since we have acc = 0 we can directly use cpu_LO[0] and cpu_HI[0], > removing needs for an 'acc' argument.
Corresponding MULT1 and MULTU1 instructions use `acc = 1' though, as do similar variations of all the other MDU instructions. Maybe the addition of the required `acc' argument could be staged for a separate patch with all the pipeline 1 MDU instructions though. Maciej
