On 2 November 2018 at 17:38, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > Hi Peter, > > On 2/11/18 12:52, Peter Maydell wrote: >> We can remove entirely the note in rebuild-expected-aml.sh >> about copying any new data files, because now they will >> be in the source directory, not the build directory, and >> no copying is required. > > > This doesn't seem true for out-of-tree builds.
In the old setup, running the rebuild-expected-aml.sh script is done in the build directory, and creates new data files in ./tests/acpi-test-data/, which must then be copied to the source directory. In the new setup, the script is still run in the build directory, but when new data files are created in ./tests/data/acpi/ they don't need to be copied anywhere, because the directory symlink means they're already in tests/data/acpi in the source directory structure. thanks -- PMM
