On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote: > On 6/11/18 15:13, Michael S. Tsirkin wrote: >> On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: >>> On 5/11/18 19:14, Michael S. Tsirkin wrote: >>>> From: Peter Maydell <peter.mayd...@linaro.org> >>>> >>>> Currently tests/hex-loader-check-data contains data files used >>>> by the hexloader-test, and configure individually symlinks those >>>> data files into the build directory using a wildcard. >>>> >>>> Using a wildcard like this is a bad idea, because if a new >>>> data file is added, nothing causes configure to be rerun, >>>> and so no symlink is added for the new file. This can cause >>>> tests to spuriously fail when they can't find their data. >>>> Instead, it's better to symlink an entire directory of >>>> data files. We already have such a directory: tests/data. >>>> >>>> Move the data files from tests/hex-loader-check-data/ to >>>> tests/data/hex-loader/, and remove the unnecessary symlinking. >>>> >>>> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >>> >>> I reviewed/tested this patch too. >> >> >> Thanks a lot Philippe! >> It is unfortunately too late to update this patch info in git >> commit history, however your help is still greatly appreciated! > > No worry, I'm not mad at all, but there might be an issue in your git PR > workflow, this series also missed your maintainer S-o-b. > > Peter: Can you add a such check in your scripts? (during next merge > window, no hurry). > > Rather than your scripts, this should be in scripts a maintainer can run > locally, such ./scripts/checkpatch.pl --maintainer or > ./scripts/checkseries.xx.
I think such tool already exists: with git-publish you can configure a "pre-publish-send-email" hook, and check your S-o-B is present. Thanks, Laurent