On Mon, Dec 10, 2018 at 06:31:59PM +0100, Igor Mammedov wrote: > On Mon, 10 Dec 2018 15:07:18 -0200 > Eduardo Habkost <ehabk...@redhat.com> wrote: > > > On Tue, Dec 04, 2018 at 06:20:04PM +0400, Marc-André Lureau wrote: > > [...] > > > Marc-André Lureau (19): > > > tests: qdev_prop_check_globals() doesn't return "all_used" > > > qom: make interface types abstract > > > qom: make user_creatable_complete() specific to UserCreatable > > > accel: register global_props like machine globals > > > qdev: move qdev_prop_register_global_list() to tests > > > qom: remove unimplemented class_finalize > > > > Patches 1-6 (above) queued on machine-next. Thanks! > let's drop patch 6 for now until we decide what to do with GPtrArray leaks
I appreciate your effort to make sure there are no memory allocations that could make Valgrind complain, but I don't see the point of keeping dead code that was never called in the tree. Are the new GPtrArray allocations different from the g_malloc0() calls in type_new() and type_initialize()? Doesn't Valgrind complain about them today? -- Eduardo