Patchew URL:
https://patchew.org/QEMU/20181214154130.4069-1-tom.des...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181214154130.4069-1-tom.des...@gmail.com
Type: series
Subject: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3da3146 Add getsockopt for settable SOL_IPV6 options
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Add getsockopt for settable SOL_IPV6 options...
ERROR: "foo* bar" should be "foo *bar"
#38: FILE: linux-user/syscall.c:2368:
+ void* target_addr;
ERROR: braces {} are necessary for all arms of this statement
#39: FILE: linux-user/syscall.c:2369:
+ if (get_user_u32(len, optlen))
[...]
ERROR: braces {} are necessary for all arms of this statement
#41: FILE: linux-user/syscall.c:2371:
+ if (len < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#45: FILE: linux-user/syscall.c:2375:
+ if (ret < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#47: FILE: linux-user/syscall.c:2377:
+ if (lv < len)
[...]
ERROR: braces {} are necessary for all arms of this statement
#49: FILE: linux-user/syscall.c:2379:
+ if (put_user_u32(len, optlen))
[...]
ERROR: "(foo*)" should be "(foo *)"
#52: FILE: linux-user/syscall.c:2382:
+ tswap32s((uint32_t*)&val);
total: 7 errors, 0 warnings, 42 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20181214154130.4069-1-tom.des...@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
