Hello Mark,
+-- On Thu, 3 Jan 2019, Mark Cave-Ayland wrote --+
| > /* Power */
| > +static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size)
| > +{
| > + return 0xffffffff;
| > +}
| > +
| >
| > static const MemoryRegionOps power_mem_ops = {
| > + .read = power_mem_read,
| > .write = power_mem_write,
| > .endianness = DEVICE_NATIVE_ENDIAN,
| > .valid = {
|
| Certainly the addition of the missing read function is valid, although I see
that
| you've defaulted reads to returning 0xffffffff - can you point me towards the
source
| that indicates that this behaviour matches that of real Ultra-5 hardware?
-> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02787.html
I haven't checked Ultra-5 h/w spec, return value was chosen similar to above
one, thinking unimplemented .read need not return success.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
