On 12/17/18 9:19 AM, Eric Blake wrote: >> >>> +@c man begin EXAMPLES >>> +Start a server listening on port 10809 that exposes only the >>> +guest-visible contents of a qcow2 file, with no TLS encryption, and >>> +with the default export name (an empty string). The command will block >>> +until the first successful client disconnects: >> >> TBH I'd always include the -t option in every example. I don't >> understand (except for backwards compatibility) why it isn't the >> default since it's something I always trip over when using qemu-nbd. > > I'd still like one example without -t, to call out specifically that it > creates a one-shot server that goes away after the first client, but > don't mind fixing the rest of the examples to use -t. > > Using -e for read-only connections makes sense, using -e for writable > exports is a bit more questionable - we _don't_ advertise the > NBD_FLAG_CAN_MULTI_CONN which states that caches are kept consistent > between simultaneous write connections, although maybe we should see if > qemu-nbd can start promising multi-write consistency in future patches?
And I see you've just posted patches for nbdkit to start advertising CAN_MULTI_CONN - so I really need to spend some time figuring out when it makes sense for qemu to advertise the flag. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
