On 17.03.2011, at 02:29, David Gibson <da...@gibson.dropbear.id.au> wrote:
> On Wed, Mar 16, 2011 at 04:47:11PM +0100, Alexander Graf wrote:
>> On 03/16/2011 05:56 AM, David Gibson wrote:
> [snip]
>>> +/* static void ics_resend(struct icp_server_state *ss) */
>>> +/* { */
>>> +/* int i; */
>>> +
>>> +/* for (i = 0; i< xics->nr_irqs; i++) */
>>> +/* ics_resend_irq(xics, nr, ss); */
>>> +/* } */
>>
>> Why is all this commented out? Better #if 0 it all away. Or even
>> better, don't include it in the patch - unless you think the code is
>> crucial and to be activated soon.
>
> Hrm, it was supposed to implement level (rather than message)
> interrupts on XICS. But I think its bitrotted since I commented it
> out. Removed.
>
>>> diff --git a/hw/xics.h b/hw/xics.h
>>> new file mode 100644
>>> index 0000000..e55f5f1
>>> --- /dev/null
>>> +++ b/hw/xics.h
>>
>> Header missing
>
> I'm not sure what you mean by this
Every source file should have a license/copyright header ;)
Alex
>
