On Thu, Jan 17, 2019 at 07:16:37PM +0300, Julia Suvorova wrote: > v4: > * Replace sprintf with g_strdup_printf [Peter] > * Move socket connection to qtest library [Peter] > * Use memcmp instead of strcmp [Stefan] > * Remove using global_qtest [Thomas] > v3: > * Fix directory leak [Stefan] > > Based-on: <20190110094020.18354-1-stefa...@redhat.com> > > Julia Suvorova (3): > tests/libqtest: Introduce qtest_init_with_serial() > tests/microbit-test: Make test independent of global_qtest > tests/microbit-test: Check nRF51 UART functionality > > tests/libqtest.c | 26 ++++ > tests/libqtest.h | 11 ++ > tests/microbit-test.c | 331 +++++++++++++++++++++++++++--------------- > 3 files changed, 250 insertions(+), 118 deletions(-)
I posted a minor comment which can be touched up when merging. Thanks for doing the global_qtest removal! Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
