On Fri, 25 Jan 2019 at 10:28, Stefan Hajnoczi <stefa...@gmail.com> wrote: > > On Thu, Jan 24, 2019 at 12:11:55PM +0100, Philippe Mathieu-Daudé wrote: > > The device realize() is also executed before the guest is started, is > > this call really necessary? > > My rationale was that machine init only happens before the guest is > started while ->realize() is called by hotplug too.
Yes, but before realize the flash memory can't actually be visible to the guest, so there's no need to invalidate anything. > That said, can pflash devices be hotplugged? I guess you could have one inside a hotplugged device in theory; they can't be directly hotpluggged. (I bet that in practice there are leaks though if you did do that, and we don't have any devices that do so today.) > If you guys prefer not flushing from pflash ->realize() then I'll drop > it. I think it makes more sense not to do a flush in the realize method. thanks -- PMM
