On 11.02.19 17:33, Peter Maydell wrote: > On Mon, 11 Feb 2019 at 16:29, David Hildenbrand <da...@redhat.com> wrote: >> >> On 05.02.19 21:05, Peter Maydell wrote: >>> This part looks like the usual "foo-softmmu/config-devices.mak isn't updated >>> if a file that's #included from default-configs/foo-softmmu.mak is >>> changed" dependency bug -- I guess the fix for that isn't in this >>> patchset ? The mips stuff is probably the same. >>> >>> I'll delete the config-devices.mak files by hand, which should >>> suffice to get the build to go through. >>> >> >> ../hw/acpi/piix4.o: In function `piix4_pm_realize': >> /home/dhildenb/git/qemu/hw/acpi/piix4.c:515: undefined reference to >> `pm_smbus_init' >> ../hw/i2c/smbus_ich9.o: In function `ich9_smbus_realize': >> /home/dhildenb/git/qemu/hw/i2c/smbus_ich9.c:89: undefined reference to >> `pm_smbus_init' >> ../hw/pci-host/piix.o: In function `i440fx_update_memory_mappings': >> /home/dhildenb/git/qemu/hw/pci-host/piix.c:149: undefined reference to >> `pam_update' >> ../hw/pci-host/piix.o: In function `i440fx_init': >> /home/dhildenb/git/qemu/hw/pci-host/piix.c:416: undefined reference to >> `init_pam' >> /home/dhildenb/git/qemu/hw/pci-host/piix.c:419: undefined reference to >> `init_pam' >> collect2: error: ld returned 1 exit status >> make[1]: *** [Makefile:207: qemu-system-x86_64] Error 1 >> make: *** [Makefile:432: subdir-x86_64-softmmu] Error 2 >> >> >> Even after make clean + configure. Which step am I missing? > > The "delete the config-devices.mak files by hand" step, I expect. > (This is working around a very long standing bug in our makefiles > which will be removed in passing by the KConfig work.)
Ah, indeed, I thought this would get fixed by a straight configure. Thanks! > > thanks > -- PMM > -- Thanks, David / dhildenb
