On 05.02.19 21:05, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 20:01, Peter Maydell <peter.mayd...@linaro.org> wrote: >> >> On Tue, 5 Feb 2019 at 18:18, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> >>> The following changes since commit 1c3d45df5e94042d5fb2bb31416072563ab30e49: >>> >>> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-02-04' >>> into staging (2019-02-05 12:46:18 +0000) >>> >>> are available in the git repository at: >>> >>> >>> git://github.com/bonzini/qemu.git tags/for-upstream >>> >>> for you to fetch changes up to 5ed76a4c63db9295c6c5d67895925810050d4a46: >>> >>> queue: fix QTAILQ_FOREACH_REVERSE_SAFE (2019-02-05 16:50:21 +0100) >>> >>> ---------------------------------------------------------------- >>> * cpu-exec fixes (Emilio, Laurent) >>> * TCG bugfix in queue.h (Paolo) >>> * high address load for linuxboot (Zhijian) >>> * PVH support (Liam, Stefano) >>> * misc i386 changes (Paolo, Robert, Doug) >>> * configure tweak for openpty (Thomas) >>> * elf2dmp port to Windows (Viktor) >>> * initial improvements to Makefile infrastructure (Yang + GSoC 2013) >>> >>> ---------------------------------------------------------------- >> >> The build tree where I do 'make clean' then 'make' failed when >> linking: > >> and >> LINK aarch64-softmmu/qemu-system-aarch64 >> hw/arm/aspeed.o: In function `palmetto_bmc_i2c_init': >> /home/petmay01/linaro/qemu-for-merges/hw/arm/aspeed.c:249: undefined >> reference to `smbus_eeprom_init_one' >> hw/arm/aspeed.o: In function `ast2500_evb_i2c_init': >> /home/petmay01/linaro/qemu-for-merges/hw/arm/aspeed.c:266: undefined >> reference to `smbus_eeprom_init_one' >> hw/arm/aspeed.o: In function `witherspoon_bmc_i2c_init': >> /home/petmay01/linaro/qemu-for-merges/hw/arm/aspeed.c:303: undefined >> reference to `smbus_eeprom_init_one' >> collect2: error: ld returned 1 exit status > > This part looks like the usual "foo-softmmu/config-devices.mak isn't updated > if a file that's #included from default-configs/foo-softmmu.mak is > changed" dependency bug -- I guess the fix for that isn't in this > patchset ? The mips stuff is probably the same. > > I'll delete the config-devices.mak files by hand, which should > suffice to get the build to go through. >
../hw/acpi/piix4.o: In function `piix4_pm_realize': /home/dhildenb/git/qemu/hw/acpi/piix4.c:515: undefined reference to `pm_smbus_init' ../hw/i2c/smbus_ich9.o: In function `ich9_smbus_realize': /home/dhildenb/git/qemu/hw/i2c/smbus_ich9.c:89: undefined reference to `pm_smbus_init' ../hw/pci-host/piix.o: In function `i440fx_update_memory_mappings': /home/dhildenb/git/qemu/hw/pci-host/piix.c:149: undefined reference to `pam_update' ../hw/pci-host/piix.o: In function `i440fx_init': /home/dhildenb/git/qemu/hw/pci-host/piix.c:416: undefined reference to `init_pam' /home/dhildenb/git/qemu/hw/pci-host/piix.c:419: undefined reference to `init_pam' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:207: qemu-system-x86_64] Error 1 make: *** [Makefile:432: subdir-x86_64-softmmu] Error 2 Even after make clean + configure. Which step am I missing? -- Thanks, David / dhildenb
