On Thu, Feb 21, 2019 at 02:03:19PM +0800, Xiao Guangrong wrote: > > >On 2/20/19 8:51 AM, Wei Yang wrote: >> Three trivial cleanup for pc-dimm. >> >> Patch [1] remove the check on class->hotpluggable since pc-dimm is always >> hotpluggable. >> Patch [2] remove nvdimm_realize >> Patch [2] remove pcdimm realize-callback >> >> v2: >> * fix warning in Patch 1 >> * split Patch 2 into two >> >> Wei Yang (3): >> pc-dimm: remove check on pc-dimm hotpluggable >> mem/nvdimm: remove nvdimm_realize > >> pc-dimm: revert "introduce realize callback" > >I think the word 'revert' is not so precise as that hints >the commit is bugly, instead, it was factored in the later >comments then becomes useless now. >
You are right. It is always difficult for me to pick up the proper word. >Anyway, this pathset looks good to me. > >Reviewed-by: Xiao Guangrong <xiaoguangr...@tencent.com> Thanks, Xiao. -- Wei Yang Help you, Help me
