On 2/25/19 8:24 AM, Murilo Opsfelder Araujo wrote: > The current 0x10000000 value is actually 256MiB, not 128MB as the comment > suggests. Move it to a constant and fix the comment (no change in the size > value). > > Signed-off-by: Murilo Opsfelder Araujo <muri...@linux.ibm.com> > --- > hw/ppc/pnv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index 000707164e..514439db20 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -56,6 +56,7 @@ > #define KERNEL_LOAD_ADDR 0x20000000 > #define KERNEL_MAX_SIZE 0x10000000 /* 256MiB */ > #define INITRD_LOAD_ADDR 0x60000000 > +#define INITRD_MAX_SIZE 0x10000000 /* 256MiB */
Why not #include "qemu/units.h" and spell this: #define INITRD_MAX_SIZE (256 * MiB) and so on for the other values? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org