Patchew URL: https://patchew.org/QEMU/20190305181602.9051-1-dgilb...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190305181602.9051-1-dgilb...@redhat.com Subject: [Qemu-devel] [PULL 00/21] migration queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190305181602.9051-1-dgilb...@redhat.com -> patchew/20190305181602.9051-1-dgilb...@redhat.com Switched to a new branch 'test' ae493dd345 qapi/migration.json: Remove a variable that doesn't exist in example dae452acf7 Migration/colo.c: Make COLO node running after failover 8d7745295b Migration/colo.c: Fix double close bug when occur COLO failover 008b59edc7 virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT 14f87199a1 migration/ram.c: add the free page optimization enable flag ca2699e456 migration/ram.c: add a notifier chain for precopy 606c6ef429 migration: API to clear bits of guest free pages from the dirty bitmap 804e796327 migration: use bitmap_mutex in migration_bitmap_clear_dirty 060dfa78ac bitmap: bitmap_count_one_with_offset 0cff623ce1 bitmap: fix bitmap_count_one ca9b2b6cdd tests: Add basic migration precopy tcp test 0c3dd1d54e migration: Create socket-address parameter 719012c3c7 tests: Add migration xbzrle test 74c0f9fd44 migration: Add capabilities validation 8c6537da13 tests/migration-test: Add a test for ignore-shared capability 2ee34efd18 migration: Add an ability to ignore shared RAM blocks 190f582e4e migration: Introduce ignore-shared capability 02a8200adf exec: Change RAMBlockIterFunc definition 1990ba02eb migration/rdma: clang compilation fix 7a26e3977e migration/rdma: Fix qemu_rdma_cleanup null check 106518cdad migration: Fix cancel state === OUTPUT BEGIN === 1/21 Checking commit 106518cdad41 (migration: Fix cancel state) 2/21 Checking commit 7a26e3977ebc (migration/rdma: Fix qemu_rdma_cleanup null check) 3/21 Checking commit 1990ba02eb5d (migration/rdma: clang compilation fix) 4/21 Checking commit 02a8200adf94 (exec: Change RAMBlockIterFunc definition) 5/21 Checking commit 190f582e4e8c (migration: Introduce ignore-shared capability) 6/21 Checking commit 2ee34efd18ee (migration: Add an ability to ignore shared RAM blocks) ERROR: Macros with multiple statements should be enclosed in a do - while loop #149: FILE: migration/ram.c:169: +#define RAMBLOCK_FOREACH_NOT_IGNORED(block) \ + INTERNAL_RAMBLOCK_FOREACH(block) \ + if (ramblock_is_ignored(block)) {} else ERROR: trailing statements should be on next line #151: FILE: migration/ram.c:171: + if (ramblock_is_ignored(block)) {} else total: 2 errors, 0 warnings, 386 lines checked Patch 6/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/21 Checking commit 8c6537da13a8 (tests/migration-test: Add a test for ignore-shared capability) ERROR: if this code is redundant consider removing it #235: FILE: tests/migration-test.c:829: +#if 0 total: 1 errors, 0 warnings, 255 lines checked Patch 7/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/21 Checking commit 74c0f9fd446e (migration: Add capabilities validation) 9/21 Checking commit 719012c3c7e2 (tests: Add migration xbzrle test) 10/21 Checking commit 0c3dd1d54ea5 (migration: Create socket-address parameter) 11/21 Checking commit ca9b2b6cdd76 (tests: Add basic migration precopy tcp test) 12/21 Checking commit 0cff623ce1ca (bitmap: fix bitmap_count_one) 13/21 Checking commit 060dfa78acbd (bitmap: bitmap_count_one_with_offset) 14/21 Checking commit 804e79632706 (migration: use bitmap_mutex in migration_bitmap_clear_dirty) 15/21 Checking commit 606c6ef42982 (migration: API to clear bits of guest free pages from the dirty bitmap) 16/21 Checking commit ca2699e45688 (migration/ram.c: add a notifier chain for precopy) 17/21 Checking commit 14f87199a142 (migration/ram.c: add the free page optimization enable flag) 18/21 Checking commit 008b59edc7e4 (virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT) 19/21 Checking commit 8d7745295b47 (Migration/colo.c: Fix double close bug when occur COLO failover) 20/21 Checking commit dae452acf7ef (Migration/colo.c: Make COLO node running after failover) 21/21 Checking commit ae493dd3459d (qapi/migration.json: Remove a variable that doesn't exist in example) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190305181602.9051-1-dgilb...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
