Patchew URL: https://patchew.org/QEMU/20190305181602.9051-1-dgilb...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190305181602.9051-1-dgilb...@redhat.com Subject: [Qemu-devel] [PULL 00/21] migration queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190305181602.9051-1-dgilb...@redhat.com -> patchew/20190305181602.9051-1-dgilb...@redhat.com Switched to a new branch 'test' ed12bcbe36 qapi/migration.json: Remove a variable that doesn't exist in example f7ebfda83a Migration/colo.c: Make COLO node running after failover 32db19110d Migration/colo.c: Fix double close bug when occur COLO failover 4ede2cb898 virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT e2179bfdaf migration/ram.c: add the free page optimization enable flag 0b2dcc781d migration/ram.c: add a notifier chain for precopy a4872ec0c9 migration: API to clear bits of guest free pages from the dirty bitmap 4d16332d3d migration: use bitmap_mutex in migration_bitmap_clear_dirty 3d43e07311 bitmap: bitmap_count_one_with_offset 81ebde4066 bitmap: fix bitmap_count_one 4805e66bc6 tests: Add basic migration precopy tcp test c2c09c0a2e migration: Create socket-address parameter 791156d5b0 tests: Add migration xbzrle test 1a91c1dc80 migration: Add capabilities validation 19953886de tests/migration-test: Add a test for ignore-shared capability 8d13ec1c7e migration: Add an ability to ignore shared RAM blocks 5a6f22f321 migration: Introduce ignore-shared capability 6e514e3671 exec: Change RAMBlockIterFunc definition 0b5d5ed075 migration/rdma: clang compilation fix 2f25212829 migration/rdma: Fix qemu_rdma_cleanup null check 8c62cfd9be migration: Fix cancel state === OUTPUT BEGIN === 1/21 Checking commit 8c62cfd9beaf (migration: Fix cancel state) 2/21 Checking commit 2f252128292b (migration/rdma: Fix qemu_rdma_cleanup null check) 3/21 Checking commit 0b5d5ed075d6 (migration/rdma: clang compilation fix) 4/21 Checking commit 6e514e3671d0 (exec: Change RAMBlockIterFunc definition) 5/21 Checking commit 5a6f22f32115 (migration: Introduce ignore-shared capability) 6/21 Checking commit 8d13ec1c7e0c (migration: Add an ability to ignore shared RAM blocks) ERROR: Macros with multiple statements should be enclosed in a do - while loop #149: FILE: migration/ram.c:169: +#define RAMBLOCK_FOREACH_NOT_IGNORED(block) \ + INTERNAL_RAMBLOCK_FOREACH(block) \ + if (ramblock_is_ignored(block)) {} else ERROR: trailing statements should be on next line #151: FILE: migration/ram.c:171: + if (ramblock_is_ignored(block)) {} else total: 2 errors, 0 warnings, 386 lines checked Patch 6/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/21 Checking commit 19953886de14 (tests/migration-test: Add a test for ignore-shared capability) ERROR: if this code is redundant consider removing it #235: FILE: tests/migration-test.c:829: +#if 0 total: 1 errors, 0 warnings, 255 lines checked Patch 7/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/21 Checking commit 1a91c1dc805c (migration: Add capabilities validation) 9/21 Checking commit 791156d5b020 (tests: Add migration xbzrle test) 10/21 Checking commit c2c09c0a2e2c (migration: Create socket-address parameter) 11/21 Checking commit 4805e66bc6b4 (tests: Add basic migration precopy tcp test) 12/21 Checking commit 81ebde4066f7 (bitmap: fix bitmap_count_one) 13/21 Checking commit 3d43e07311cc (bitmap: bitmap_count_one_with_offset) 14/21 Checking commit 4d16332d3d3c (migration: use bitmap_mutex in migration_bitmap_clear_dirty) 15/21 Checking commit a4872ec0c961 (migration: API to clear bits of guest free pages from the dirty bitmap) 16/21 Checking commit 0b2dcc781dd5 (migration/ram.c: add a notifier chain for precopy) 17/21 Checking commit e2179bfdafa8 (migration/ram.c: add the free page optimization enable flag) 18/21 Checking commit 4ede2cb898e0 (virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT) 19/21 Checking commit 32db19110de5 (Migration/colo.c: Fix double close bug when occur COLO failover) 20/21 Checking commit f7ebfda83a46 (Migration/colo.c: Make COLO node running after failover) 21/21 Checking commit ed12bcbe36cf (qapi/migration.json: Remove a variable that doesn't exist in example) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190305181602.9051-1-dgilb...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
