On 07/03/2019 18:23, Richard Henderson wrote: > On 3/7/19 10:05 AM, Mark Cave-Ayland wrote: >> It isn't possible to include internal.h from cpu.h so move the Vsr* macros >> into cpu.h alongside the other VMX/VSX register access functions. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> target/ppc/cpu.h | 20 ++++++++++++++++++++ >> target/ppc/internal.h | 19 ------------------- >> 2 files changed, 20 insertions(+), 19 deletions(-) > > Although to some extent I think we should be minimizing the amount > of code within cpu.h, to avoid rebuilding the world. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Yeah - I did notice that quite a bit during testing, but when looking at cpu.h after the final patch was reasonably convinced that these shouldn't need to be changed again... ATB, Mark.
